Re: [PATCH] Honor HP C's noreturn attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Junio,

On 8.3.2011, at 20:00, Junio C Hamano wrote:

> Michal Rokos <rokos@xxxxxxxxxxx> writes:
> 
>> The __HP_cc define detects the HP C compiler version. Precede the
>> __GNUC__ check so it works well when compiling with HP C using -Agcc
>> option that enables partial support for the GNU C dialect. The -Agcc
>> defines the __GNUC__ too.
> 
> I love it when people write a very readable log message to explain why the
> patch _has_ to be the way it is.  Very good job.
> 
> Except for the overlooooooooong lines in the message, which I line-wrapped
> locally before applying, that is.


thank you for your review. I will try to improve overall patch and the commit
log quality when sending something more.

Michal

--

Michal Rokos

NextSoft spol. s r.o.
VyskoÄilova 1/1410
140 21 Praha 4
Czech Republic
mobile: +420 736 646 591
fax:    +420 267 224 307
e-mail: rokos@xxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]