2011/3/4 Junio C Hamano <gitster@xxxxxxxxx>: > Piotr Krukowiecki <piotr.krukowiecki@xxxxxxxxx> writes: > >> From: Piotr Krukowiecki <piotr.krukowiecki@xxxxxxxxx> >> Date: Thu, 3 Mar 2011 21:51:34 +0100 >> Subject: [PATCH] Improve error message when gitfile has wrong format >> >> Add information what format of .git file is expected. > > Don't do this. We don't want to _add_ places that needs to be updated > when we need to update our internal implementation. I thought it was user-level file, like $GIT_DIR I'm not into data duplication, but in this case the message is next to the previous use: if (prefixcmp(buf, "gitdir: ")) die("Invalid gitfile format: %s\nUse gitdir: <PATH>", path); BTW I think it might be enough to have just path in the .git file. If .git has path to a correct git repo then chances it's coincidence are quite low. (The format does not matter if it's internal file of course) -- Piotrek -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html