Re: [PATCH v2 18/31] rebase: extract merge code to new source file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 25, 2011 at 12:27:03PM -0800, Jakub Narebski wrote:

> > > Yes, sourced scripts should not have an executable bit. See 46bac90 for
> > > rationale.
> > 
> > And I should have mentioned: they should go in SCRIPT_LIB in the
> > Makefile, not SCRIPT_SH.
> 
> Shouldn't this information be in Documentation/CodingGuidelines, and
> perhaps also (checking if one doesn't accidentally change executable
> bit on sourced scripts) in Documentation/SubmittingPatches?

I think it might make more sense as comments in the Makefile, which is
not very well commented for people tweaking non-config bits. Patches
welcome.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]