On Tue, Mar 1, 2011 at 3:08 PM, Jeff King <peff@xxxxxxxx> wrote: > On Tue, Mar 01, 2011 at 02:57:19PM -0500, Chad Joan wrote: > >> > Exactly. Rather than spend time figuring out if the directory is >> > removable (which would not be atomic, anyway), we just rmdir and ignore >> > the error condition. >> > >> > I would argue that your filesystem is broken. Even if we implemented a >> > workaround to opendir() and check for files, it would still have a race >> > condition that could cause this situation to occur. >> >> Ouch. >> >> Would it work to do something like alias rmdir to a script or program >> that would call /bin/rmdir and then fix up the permissions? > > Well, we're using the rmdir system call, so you would need a patch to > git either way. If that was something we wanted to support (with a > config option, of course), we could do the permissions check-and-restore > ourselves. > > But it just seems horribly broken to me. This is CIFS to an OpenVMS > machine you said? Do the broken permissions appear to other clients or > across a remount (i.e., is it broken state in your CIFS client, or has > the server actually munged permissions)? If so, have you tried reporting > the issue to whoever writes CIFS server on OpenVMS (is it just samba)? > > -Peff > Yep, CIFS to OpenVMS. I don't know about other clients because there are none (yet). The permission change does survive remounting. I haven't reported it. I didn't know it existed until now ;) I'll do that, but it will probably take a long long time for me to see the patch. I'm hoping there's some cheap hack I can use to work around it in the meantime. - Chad -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html