This patch series fixes a bug reported by Stephen Rothwell -- that
during merges git would unnecessarily update modification times of
files.
There are two testcases included in this patch series. The first is a
simple case to test the originally reported bug; this testcase is
fixed in this series (as is Stephen's original linux-next testcase).
The second testcase suffers from the exact same problem, but arises
from a different situation and is not fixed in this series. That
testcase is slightly harder to solve because:
* unpack_trees + threeway_merge throws away the original index entry
with stat information when it notices the directory/file conflict
* make_room_for_directories_of_df_conflicts() must remove such files
from the working copy or the corresponding directory and files
below it will be unable to be written to the working copy (which
can cause spurious conflicts, or make resolving conflicts very
hard for users who don't know how to access the many files missing
from their working copy).
We could fix this second testcase by recording stat information for
files removed by make_room_for_directories_of_df_conflicts(), and
then, if those files are reinstated at the end of conflict resolution
(i.e. the directory of the D/F conflict went away during the merge),
then call utime() to reset the modification times on those files back
to what they originally were.
(Technically, the second testcase that I left unfixed is not a
regression; prior versions of git would fail the merge and record the
file's content in an alternative file to "avoid" the directory it
thought was in the way, so the modification time was the least of the
worries.)
Elijah Newren (3):
t6022: New test checking for unnecessary updates of renamed+modified files
t6022: New test checking for unnecessary updates of files in D/F conflicts
merge-recursive: When we detect we can skip an update, actually skip it
merge-recursive.c | 17 +++++++----
t/t6022-merge-rename.sh | 68 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 79 insertions(+), 6 deletions(-)
--
1.7.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html