Re: [PATCH 2/2] push: better error messages for detached HEAD and "no destination"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 28, 2011 at 4:14 PM, Matthieu Moy <Matthieu.Moy@xxxxxxx> wrote:

> ---
> Âbuiltin/push.c | Â 12 ++++++++++--
> Â1 files changed, 10 insertions(+), 2 deletions(-)
>
> @@ -152,7 +153,14 @@ static int do_push(const char *repo, int flags)
> Â Â Â Âif (!remote) {
> Â Â Â Â Â Â Â Âif (repo)
> Â Â Â Â Â Â Â Â Â Â Â Âdie("bad repository '%s'", repo);
> - Â Â Â Â Â Â Â die("No destination configured to push to.");
> + Â Â Â Â Â Â Â die("No destination configured to push to.\n"

The dangling preposition is awkward. How about:

  No configured push destination.

Or

  Push destination not configured.

> + Â Â Â Â Â Â Â Â Â "Either specify the URL from the command line or configure a remote repository using\n"

Maybe "Either specify the URL explicitly or configure..."

> + Â Â Â Â Â Â Â Â Â "\n"
> + Â Â Â Â Â Â Â Â Â " Â Âgit remote add <name> <url>\n"
> + Â Â Â Â Â Â Â Â Â "\n"
> + Â Â Â Â Â Â Â Â Â "and then push using the remote name like\n"

s/like//

> + Â Â Â Â Â Â Â Â Â "\n"
> + Â Â Â Â Â Â Â Â Â " Â Âgit push <name>\n");

Well, I just bikeshedded that 3 different colors, didn't I? You're welcome. :-)

j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]