On Thu, Feb 24, 2011 at 04:14, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Ãvar ArnfjÃrà Bjarmason wrote: > >> Anyway, to be blunt I really don't see the point of fiddling around >> with this bit so much. Whether it's a `"GETTEXT POISON"` constant or >> `rot13(msgid)` the same tests will fail. > > Because with rot13 you can decode the message and find the problematic > code? > >> If someone else wants to do the work I don't care. I just think >> there's more important things to worry about. > > I already wrote a patch. ÂI imagine you don't intend it this way, but > I keep on hearing "we shouldn't do what you've already done. ÂIt's too > much trouble. ÂYou wasted your time." I don't mean it that way at all, I just mean that as a comment to *this* particular patch series I don't think it's something we have to worry about. I.e. if you look at this in context we have a 170 gettext patch series to trickle in gradually. Right now we have 70 pending with only the C translations. Hopefully we can fast-track this to have around 150 of those in in the next month or so. What I want to focus on is getting this right for users of Git, and I think it's already good enough for that purpose. I'm not worried about an embedded debug testing mode that to my knowledge only you and I have used so far. If it has some changes for improvement I think they can be dealt with later, doing it at this point means more code to review. Right now the C code in the series is around 10 lines, doing something like the rot13 implementation would at least triple that, making in not leak memory (and hence have automated tools complain) would be even more code. Again, don't get me wrong. I really appreciate your work. I just don't think this is something we need to worry about now. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html