Ãvar ArnfjÃrà Bjarmason wrote: > On Thu, Feb 24, 2011 at 02:16, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >>> I still don't like the #-sign business in this commit. ÂCouldn't it >>> be split into a separate patch, not to be applied until just before >>> the strings in commit/tag/wt-status are marked for translation? >> >> That might be a sensible thing to do.  Ãvar what do you think? > > It could, but I don't want to spend time on it. That doesn't answer the question, does it? The question is whether you'd be okay with the change (in which case we should do it --- it's not like there's a shortage of people willing to write a one-line patch) or not (in which case we shouldn't). >> Yeah I would imagine it would leak. ÂAlso blindly running rot13 to turn %d >> into %q is probably not what you want. The rot13 patch turns %d into 5q (and 5q into "d). I think that aspect can wait for later, of course --- a fixed string is not actively bad or confusing. > Of course there might be cases where a test will fail because it's > supposed to end in \n but the poison string doesn't, but since none of > them did I didn't worry about that. Right, that's a downside to the rot13 patch --- it takes \n to \n so it wouldn't catch such cases. Easily fixable, though. > I'd much > rather have a few more tests skipped under this poison mode than 20 > extra lines of C code that effectively give us nothing No disagreement here. I think some cases (e.g., adding '# ' before each line of the translated status hints) would give us something, namely protection against hard-to-debug translation bugs. Sorry for the grouchiness, and hope that helps. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html