Jens Lehmann <Jens.Lehmann@xxxxxx> writes:
> diff --git a/submodule.c b/submodule.c
> index cccd728..b477c3c 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -113,7 +113,7 @@ int parse_submodule_config_option(const char *var, const char *value)
> if (!config)
> config = string_list_append(&config_fetch_recurse_submodules_for_name,
> strbuf_detach(&submodname, NULL));
> - config->util = git_config_bool(var, value) ? (void *)1 : NULL;
> + config->util = (void *)(size_t)parse_fetch_recurse_submodules_arg(value);
What is this double-cast about?
> @@ -376,8 +376,13 @@ int fetch_populated_submodules(int num_options, const char **options,
> ...
> + if ((size_t)fetch_recurse_submodules_option->util == RECURSE_SUBMODULES_OFF)
> continue;
> + if ((size_t)fetch_recurse_submodules_option->util == RECURSE_SUBMODULES_ON_DEMAND) {
Likewise here; size_t feels a strange type to cast to in this comparison
between (void *) and an enum, no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html