Re: [PATCH v2 5/8] git-p4: reinterpret confusing p4 message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 19, 2011 at 2:17 PM, Pete Wyckoff <pw@xxxxxxxx> wrote:
> Error output will look like this:
>
> glom$ git p4 clone //deopt
> Importing from //deopt into .
> Reinitialized existing Git repository in /tmp/x/.git/
> Doing initial import of //deopt from revision #head into refs/remotes/p4/master
> p4 returned an error: //deopt/... - must refer to client glom.
>
> This particular p4 error is misleading.
> Perhaps the depot path was misspelled.
> Depot path: Â//deopt
>
> Signed-off-by: Pete Wyckoff <pw@xxxxxxxx>

Acked-by: Tor Arvid Lund <torarvid@xxxxxxxxx>

:-)

> ---
> Âcontrib/fast-import/git-p4 | Â Â4 ++++
> Â1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index db19b17..6b847c4 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1445,6 +1445,10 @@ class P4Sync(Command):
> Â Â Â Â Â Â if 'code' in info and info['code'] == 'error':
> Â Â Â Â Â Â Â Â sys.stderr.write("p4 returned an error: %s\n"
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â% info['data'])
> + Â Â Â Â Â Â Â Âif info['data'].find("must refer to client") >= 0:
> + Â Â Â Â Â Â Â Â Â Âsys.stderr.write("This particular p4 error is misleading.\n")
> + Â Â Â Â Â Â Â Â Â Âsys.stderr.write("Perhaps the depot path was misspelled.\n");
> + Â Â Â Â Â Â Â Â Â Âsys.stderr.write("Depot path: Â%s\n" % " ".join(self.depotPaths))
> Â Â Â Â Â Â Â Â sys.exit(1)
> Â Â Â Â Â Â if 'p4ExitCode' in info:
> Â Â Â Â Â Â Â Â sys.stderr.write("p4 exitcode: %s\n" % info['p4ExitCode'])
> --
> 1.7.4.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]