On Mon, Feb 21, 2011 at 11:13, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Âstatic inline FORMAT_PRESERVING(1) const char *_(const char *msgid) > Â{ > - Â Â Â return msgid; > + Â Â Â return use_poison() ? "Malkovich" : msgid; > Â} Why did you change this from "# GETTEXT POISON #" to "Malkovich"? The reason it started with a "#" is because many rebase tests were broken otherwise. The reason it was in all caps was so that when I run the tests in debug mode it's really easy to see at a glance if I'm encountering these strings. Do those tests still pass with this new string, and is there any reason to change this? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html