Re: [RFC/PATCH 0/3] Thinning the git toplevel directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 18, 2011 at 4:25 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Changes since the series sent to the list:
> ...
> Â- renamed nonbuiltin/ to commands/. ÂNames like
> Â commands/add--interactive.perl even seem to make a kind of sense.

I suggest cmds/ to avoid tab-completion conflict with compat.

> Â- moved the http support mini-library to http/.

Move them to commands/ as well?

> Â- renamed git_remote_helpers to python/, though I'm not very happy
> Â about that.

It don't like having "perl" and "python" directories (makes me thing
what if another language appears). If they are just bindings (python
dir may not be), how about "bindings" directory and throw them all
flat in there?

> This is all very off-the-cuff. ÂI'd be happy for others to pick this
> up and remold it to their taste (after all, I'm too used to the
> current layout to remember what matters). ÂIt doesn't feel cooked yet.

A few more things:

 - I like the fact that you leave only git.c in topdir. Straight entry
point for newcomers.
 - On the same topic of newcomers, should we pull
Documentation/technical out to topdir? A symlink is OK.
 - test-programs should be still in t/ though. I'm not an advocate for
deep layout, but it makes sense to me to keep test programs close to
test scripts.
 - perhaps we can merge block-sha1 and ppc into one? We can rename
ppc/sha1.* to sha1/ppc-sha1.*
 - I agree with Jeff that generated files should stay in the same
place with source files. Although I tend to use "git ls", untracked
files do not bother me much ;-)
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]