On Fri, Feb 18, 2011 at 11:12:42AM +0100, Michael J Gruber wrote: > Currently, patch-id trips over the diff extension for marking > the absence of newline at EOF. > > Fix it. (Ignore it, it's whitespace.) > > This uses the same detection rationale as in buitlin/apply.c, which was > introduced in > > 433ef8a ([PATCH] Make git-apply understand incomplete lines in non-C locales, 2005-09-04) Thanks, this looks good to me, with one style nit: > + else if (!memcmp(line, "\\ ", 2) && strlen(line)>=12) > + continue; Whitespace around relational operators. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html