On Sat, Feb 12, 2011 at 21:12, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> writes:
>> Â Â *** TODO Introduce a skeleton no-op gettext, just the
>> infrastructure minus the interesting stuff
>>
>> Â Â Â Â I.e. just add:
>>
>> Â Â Â Â Â Â #define N_(s) (s)
>> Â Â Â Â Â Â #define _(s) (s)
>>
>> Â Â *** TODO Add no-op C gettextize patches
>>
>> Â Â Â Â This will change "foo" to _("foo") everywhere, but will be a no-op
>> Â Â Â Â due to it being macroed out.
>
> It would be best to get this as early as possible while not many topics
> are in 'next'; it is preferrable if we can rebase other topics in 'pu' on
> top of the result of this step.
Here's a work-in-progress version of this:
https://github.com/avar/git/compare/master...ab/i18n-c-_-only
I still have to:
* Add NO_GETTEXT_POISON to more tests, some things have broken due to
new strings / changed tests.
* Squash the !fixup patches in appropriately.
But otherwise does this seem good? I.e. having just those stub macros,
a lot of *.c patches, including gettext.h in cache.h.
And having NO_GETTEXT_POISON be part of the actual patches, of course
I'd also have to add something to the test suite to always set that
for now.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html