Re: non-empty index with git commit -a

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sverre Rabbelier <srabbelier@xxxxxxxxx> writes:

> On Wed, Feb 16, 2011 at 08:51, Jeff King <peff@xxxxxxxx> wrote:
>> I can just as easily run "git add -u", or "git add -p" on top of some
>> changes and then realize afterwards that I actually wanted the previous
>> index state.
>
> I disagree, those are all index manipulation tools, `git commit -a` is not.

"git commmit" is not an index-manipulation tool.  Giving "-a" or pathspec
to the command however is.

Having said that, exactly because "commit" _feels_ more like a
point-of-no-return than a mistaken second "add" to the end user (even
though it is not technically different), I think it is Ok to add a
configuration that makes the command bail out when "-a" is given and there
are changes to the index.  I don't think it is sane to trigger the same
safety when a pathspec is given, though.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]