On Sun, Feb 13, 2011 at 02:53:37AM -0500, Jeff King wrote: > No, that's not right. It breaks the use-whole-paragraph feature. The > right fix is to encode the embedded newline in the subject properly. Hrm. It is actually a little more complex. Right now for a subject like: one two three we will convert that to the subject "one two three" for "git log --oneline" output. But for email messages, we actually return "one\n two\n three", which is conflating header folding with the actual construction of the title. Shouldn't we still be generating "one two three", encoding it via rfc2047 if necessary, and _then_ deciding if folding is required? Yes, individual lines in a multi-line subject are good candidates for folding, but don't we need to be checking for and folding long lines anyway? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html