On Sat, Feb 12, 2011 at 3:26 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes: >> Â Â NOTE! This does *not* obviate the need for the caller to do the *exact* >> Â Â pathspec match later. It's a first-level filter on "read_directory()", but >> Â Â it does not do the full pathspec thing. Maybe it should. But in the >> Â Â meantime,... > > I was around back then, so I know how the code came about ;-) > > The pieces used in the pathspec limiting logic have been restructured well > enough that I suspect it may now be feasible for us to revisit the "Maybe > it should" part in the above quote. ÂThanks to nd/struct-pathspec topic, I > think we are already half-way there. I was around too, just oblivious about things. I can look into that. Need to think a bit how to save what pathspecs are "seen", so that prune_directory() in builtin/add.c can be dropped. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html