Re: [PATCH v5 2/4] merge: introduce setup_merge_commit helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jared Hance <jaredhance@xxxxxxxxx> writes:

>  	for (i = 0; i < argc; i++) {
> -		struct object *o;
> ...
> -		strbuf_reset(&buf);
> +		setup_merge_commit(&buf, &remotes, argv[i]);
>  	}

Micronit; the body becomes a single statement and you should lose the {}.

Thanks.  No need to resend.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]