Hi Erik,
Erik Faye-Lund writes:
> A very superficial review, because I don't have much time, and don't
> know the surrounding code well. Sorry about that.
Thanks. I have to often switch back and fourth between GNU-style (for
Subversion) and Linux-style (for Git), so please bear with my silly
style errors.
> On Tue, Feb 1, 2011 at 3:26 PM, Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote:
> > + if (!val) die("Malformed author line");
> > + if (!(tz_off = strrchr(val, ' '))) goto error;
> > + *tz_off++ = '\0';
> > + if (!(t = strrchr(val, ' '))) goto error;
>
> style: use
> "if (x)
> do_stuff();"
> instead of
> "if (x) do_stuff();"
This was intentional -- I'm only using it when do_stuff() is 'goto
error'. I thought it looked nicer that way.
-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html