On Wed, Jan 26, 2011 at 12:43:25PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > These variables should generally not be set in one's > > environment, but they do get set by rebase, which means > > doing an interactive rebase like: > > > > pick abcd1234 foo > > exec make test > > > > will cause false negatives in the test suite. > > Cute. Thanks. BTW, for anyone interested, I am using this with the following script: -- >8 -- #!/bin/sh upstream=`git rev-parse --symbolic-full-name "$1@{u}" >/dev/null 2>&1` GIT_EDITOR='sed -i "/^pick .*/aexec make -j8 test"' \ git rebase -i "${upstream:-origin}" $1 -- 8< -- which is a convenient way of testing each commit in a patch series before submitting it upstream (and it stops on test failure so you can fix up that commit). You can drop it in your PATH as "git-test" and run "git test" or "git test <branch>". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html