Jonathan Nieder wrote: > [...] > So after building from a tarball generated with "git archive", "git version" > produces v1.7.4-rc1, producing errors from gitk, but after building > from the git repo or a tarball generated with "make dist", the version > is v1.7.4.rc1 (which gitk accepts). > > Anders's fix looks good to me for robustness reasons anyway, so > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > OK then. Junio? :) > Maybe the substitution in GIT-VERSION-GEN should say something like > > VN=$(echo "$VN" | sed -e 's/-\([^r]\)/.\1/g') > > meaning the result for tagged rcs would not depend on whether git is > present? Alternatively, DEF_VER could be set to v1.7.4.rc1, which > does not seem as nice to me. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html