Re: [PATCH] svndump.c: Fix a printf format compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder wrote:
> Ramsay Jones wrote:
> 
>> --- a/vcs-svn/svndump.c
>> +++ b/vcs-svn/svndump.c
>> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>>  		if (key == keys.svn_fs_dump_format_version) {
>>  			dump_ctx.version = atoi(val);
>>  			if (dump_ctx.version > 2)
>> -				die("expected svn dump format version <= 2, found %d",
>> +				die("expected svn dump format version <= 2, found %"PRIu32,
>>  				    dump_ctx.version);
> 
> Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Thanks!

> I think we should just use "int", but that is a wider sweeping change
> for another time.  Thanks.
> 
> Does gcc or sparse provide a warning that could have caught this
> mistake?

None that I know of, no ... :(

ATB,
Ramsay Jones



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]