Hi Peter,
Peter Baumann writes:
> > + while ((t = buffer_read_line(&input))) {
> > + val = strchr(t, ' ');
> > + if (!val) {
> > + if (!memcmp(t, "blob", 4))
> > + active_ctx = BLOB_CTX;
> > + else if (!memcmp(t, "deleteall", 9))
> > + ;
> > + continue;
>
> Having actually no idea what the input you are reading from might look like, but
> seeing those two memcmp compares above makes me wonder if 't' might ever be smaller
> than 4 (or 9 for the else part). Which obviously would lead to a SEGFAULT.
> In the code below there are also memcmp class which might step out of the
> buffer.
Right. Silly mistake on my part. Thanks for pointing it out.
There are probably many more trivial mistakes- I was in a hurry to get
/something/ working, and didn't have a chance to clean up the code.
-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html