Re: Git Rebase blows away GIT_AUTHOR_NAME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 14, 2011 at 10:28:58AM -0800, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > So we should probably do one or both of:
> >
> >   1. Make an --allow-any-name option to mailinfo, and use it when we
> >      invoke mailinfo internally for rebasing. That still doesn't solve
> >      the emailed patch problem, but at least keeps purely internal
> >      operations sane.
> >
> >   2. Bump the check up to git-commit time, which is the best place to
> >      catch and tell somebody that their name is too short, because they
> >      can actually fix it.
> >
> > Even if we dropped the check now, option (2) is still useful, because
> > you have no idea which version of git the other end will use to apply
> > your patch.
> 
> I am perfectly Ok with making the check looser in "am" when $rebasing is
> in effect.  Wouldn't that solve the issue?

More or less. You would still have some lossiness when emailing your
patch. Do we want to warn about that?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]