On Fri, Jan 14, 2011 at 05:30:51PM +0100, Erik Faye-Lund wrote: > > Â2. Bump the check up to git-commit time, which is the best place to > > Â Â catch and tell somebody that their name is too short, because they > > Â Â can actually fix it. > > > > The problem with (2) is that git-am uses git-commit-tree rather than > git-commit. But I do think that adding the same checks to git-commit > would make sense. Unless we decide to remove the checks, that is... Yeah, I didn't say it very clearly, but I meant to factor the check out and use it also in git-commit (probably as a warning, the same way we do with other ident verification in print_summary(). Even if we remove the check, it may still be worthwhile to say "Just so you know, older versions of git may mangle the name you have chosen". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html