Re: [PATCH] git-p4: correct indenting and formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Garber <andrew@xxxxxxxxxxxxxxxx> writes:

> - replace tabs with appropriate number of spaces
> - minor tweaks to code formatting
> ---
>  contrib/fast-import/git-p4 |   71 +++++++++++++++++++++-----------------------
>  1 files changed, 34 insertions(+), 37 deletions(-)

Sorry, but in git codebase, tabs are 8-place indent by definition, and I
don't see much merit in this patch, other than being religious about
somebody else's coding style, which would matter only if we are trying to
get this included in "batteries included" set shipped with Python
distribution, perhaps.

A downside is that this patch will make life harder for people with
private patches to git-p4 that they haven't shared with us.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]