Re: [PATCH v2] Introduce new configuation option to override committer information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
> 
> > The 'user.name' and 'user.email' configuration
> > options set both author and committer information. To solve this,
> > introduce 'user.committername' and 'user.committeremail' configuration
> > options to override committer name and email respectively.
> 
> Predictably, I don't like this idea at all.  How would we explain this
> to a new user that is reading over gitconfig(5) for the first time?
> It makes the semantics of the committer and author name (that are mostly
> meant for giving credit and a contact address) much more murky.

Well, now that I'm rethinking it, the weird thing is that it does not
override in the way that the user intuitively might expect.

Assume we also had user.authoremail for completeness, and you do

  git config --global user.authoremail author@xxxxxxxxxxx
  git config --global user.committeremail committer@xxxxxxxxxxx
  git config user.email user@xxxxxxxxxxx

Probably the user would expect this to result in a uniform
user@xxxxxxxxxxx identity for the current repo, but I don't think we
can twist it that way with the current config infrastructure.  The
obvious option of having user.{author,committer}* override the more
generic user.* would be contrary to that intuition.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]