On Tue, Jan 11, 2011 at 4:01 PM, Johan Herland <johan@xxxxxxxxxxx> wrote: > On Tuesday 11 January 2011, Jeenu V wrote: >> My core.editor value in $HOME/.gitconfig is set to >> >> [core] >> editor = vi "+set tw=72 spell" >> >> so that I've text width of 72 with spell check turned on. I haven't >> found problems with any git commands that invoke editor, but notes. >> 'git notes' seems to invoke the vi for me with 3 separate arguments >> instead of just one: "+set, tw=72, and spell". In other words, I >> don't think it honors shell quoting for editor config variable. >> >> Could this be a bug? > > Indeed, it could, but I cannot immediately see what causes it. In > current 'master', builtin/notes.c launches the editor like this: > > if (launch_editor(path, &(msg->buf), NULL)) ... > > while builtin/commit.c lauches the editor like this: > > if (launch_editor(git_path(commit_editmsg), NULL, env)) ... > > In both cases, the details of interpreting core.editor is left to > git_default_core_config(), and passed to launch_editor() using the > editor_program global variable. AFAICS there is no difference between > how "notes" and "commit" interprets core.editor. > > What Git version are you running? $ git --version git version 1.7.0.4 -- Jeenu -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html