Re: [PATCH] submodule: fix relative url parsing for scp-style origin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/10/2011 12:01 PM, Junio C Hamano wrote:
Thomas Rast<trast@xxxxxxxxxxxxxxx>  writes:

The function resolve_relative_url was not prepared to deal with an
scp-style origin 'user@host:path' in the case where 'path' is only a
single component.  Fix this by extending the logic that strips one
path component from the $remoteurl.

Also add tests for both styles of URLs.

Noticed-by: Jeffrey Phillips Freeman<jeffrey.freeman@xxxxxxxxxxxx>
Signed-off-by: Thomas Rast<trast@xxxxxxxxxxxxxxx>
---

If Mark agrees with the fix, I think this should go in before 1.7.4
since it's a pretty annoying bug.
Seems obvious to me from a cursory look; thanks.


Looks ok to me. (FWIW, note that the original function handles user@host:~/path just fine :^).


Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]