Yann Droneaud <yann@xxxxxxxxxxx> writes:
> Signed-off-by: Yann Droneaud <yann@xxxxxxxxxxx>
> ---
> t/t9100-git-svn-basic.sh | 25 ++++++++-----------------
> t/t9129-git-svn-i18n-commitencoding.sh | 13 +++----------
> 2 files changed, 11 insertions(+), 27 deletions(-)
Both are nice changes; this patch shows the earlier abstraction in 2/4 is
the right direction to go.
> compare_svn_head_with () {
> # extract just the log message and strip out committer info.
> # don't use --limit here since svn 1.1.x doesn't have it,
> - LC_ALL="$a_utf8_locale" svn log `git svn info --url` | perl -w -e '
> + LC_ALL=$GIT_LC_UTF8 svn log `git svn info --url` | \
> + LC_ALL=$GIT_LC_UTF8 perl -w -e '
Style.
LC_ALL=... svn log ... |
LC_ALL=... perl -w -e '
...
'
When you end a line with '|', the shell knows that you haven't finished
talking to it, so there is no need for the trailing bs-lf there. Indent
the downstream of the pipe to the same level as the upstream.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html