Re: git mergetool broken when rerere active

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 5 Jan 2011, Martin von Zweigbergk wrote:

>  (2) When running mergetool again after resolving some (or all)
>      conflicts, so that some of the files have already been added to
>      the index, mergetool will now print something like
> 
>      file1: file does not need merging
>      Continue merging other unresolved paths (y/n) ?
> 

The same problem should arise even the first time mergetool if run if
rerere autoupdate is active and has added some files to the index.

> I would like to have both the original properties in (1) and (2) back,
> i.e. being ready for commit once 'git mergetool' has been successfully
> completed, and having it ignore any files that have already been added
> to the index.

Well, if rerere.autoupdate is disabled, any files resolved by rerere
should not be touched by 'git mergetool' (this was the original
request that lead to the change), but they would not be added to the
index, so we would not be ready for commit. I take that part of my
request back. I guess it would be ok (or even necessary) if, after
resolving all the conflicts reported by 'git mergetool', the user
would still have to explicitly add any files resolved by rerere and
thus ignored by 'git mergetool'.

So I guess what I'm saying here, is that I think only the problem with
'delete/modify' conflicts should be fixed regarding issue (1).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]