"Vallon, Justin" <Justin.Vallon@xxxxxxxxxx> writes: > How was SHELL=/bin/false causing problems? Is git using $SHELL? The explanation is in the comment right above the modification in the patch. "user's shell" can be read as "$SHELL": > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -71,8 +71,9 @@ test_expect_success 'setup' ' > # "exec" commands are ran with the user shell by default, but this may > # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work > # to create a file. Unseting SHELL avoids such non-portable behavior > -# in tests. > +# in tests. It must be exported for it to take effect where needed. > SHELL= > +export SHELL (my bad, I wrote this SHELL= without exporting it. Since bash re-exports already exported variables when they are assigned, and my /bin/sh points to bash, I didn't notice) -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html