Zapped wrote:
> Signed-off-by: Zapped <zapped@xxxxxxx>
As Junio already said, please provide a real name for the sign-off.
But I also found the commit message and content confusing, probably
because I haven't programmed Pascal for 15 years.
You said
Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal
> PATTERNS("pascal",
> - "^((procedure|function|constructor|destructor|interface|"
> + "^(((class[ \t]+)?(procedure|function)|constructor|destructor|interface|"
> "implementation|initialization|finalization)[ \t]*.*)$"
> "\n"
> "^(.*=[ \t]*(class|record).*)$",
But the last line very conspicuously already mentions 'class', so why
does it fail?
I had to look up a bit of Pascal syntax. Google helped with
http://www.freepascal.org/docs-html/ref/ref.html
which answers this. Also, as stated in SubmittingPatches, we
generally word the messages as stating the behaviour of the changed
version in the present tense. So a better commit message would be
userdiff: match Pascal class methods
Class declarations were already covered by the second pattern, but
class methods have the 'class' keyword in front too. Account for
it.
Signed-off-by: ÐÐÐÐÑÐÐ ÐÑÐÐÐÐ <zapped@xxxxxxx>
Ok, now I feel silly for only having a two-liner despite my
complaints.
That being said, I have now verified that the patch is good, and, you
can include my
Acked-by: Thomas Rast <trast@xxxxxxxxxxxxxxx>
in a reroll if you fix the above.
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html