Johannes Sixt <j6t@xxxxxxxx> writes: > On Freitag, 31. Dezember 2010, Jonathan Nieder wrote: >> Johannes Sixt wrote: >> > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote: >> >> in your patch does not. Does bash auto convert value in >> >> TRASH_DIRECTORY="$TE..." line? >> > >> > No. When this line is executed: >> > >> > TEST_DIRECTORY=$(pwd) >> > >> > $(pwd) still has its default behavior to return the POSIX style path. pwd >> > is redefined to pwd -W only later. >> >> Would it make sense to change it to >> >> TEST_DIRECTORY=$PWD >> >> for clarity and robustness against code movement, then? > > Yes, that would make sense. It will be very much appreciated to add a few sentences to clarify this to "Do's and don'ts" section of t/README if you are re-rolling this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html