Sylvain Rabot <sylvain@xxxxxxxxxxxxxx> writes:
> Signed-off-by: Sylvain Rabot <sylvain@xxxxxxxxxxxxxx>
> ---
> gitweb/gitweb.perl | 8 ++++----
> gitweb/static/gitweb.css | 5 +++++
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index eae75ac..cb169c7 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5146,13 +5146,13 @@ sub git_remote_block {
>
> if (defined $fetch) {
> if ($fetch eq $push) {
> - $urls_table .= format_repo_url("URL", $fetch);
> + $urls_table .= format_repo_url("<span class=\"metadata_remote_fetch_url\">URL</span>", $fetch);
> } else {
> - $urls_table .= format_repo_url("Fetch URL", $fetch);
> - $urls_table .= format_repo_url("Push URL", $push) if defined $push;
> + $urls_table .= format_repo_url("<span class=\"metadata_remote_fetch_url\">Fetch URL</span>", $fetch);
> + $urls_table .= format_repo_url("<span class=\"metadata_remote_push_url\">Push URL</span>", $push) if defined $push;
> }
> } elsif (defined $push) {
> - $urls_table .= format_repo_url("Push URL", $push);
> + $urls_table .= format_repo_url("<span class=\"metadata_remote_push_url\">Push URL</span>", $push);
> } else {
> $urls_table .= format_repo_url("", "No remote URL");
> }
I'm not sure if in this situation if it would not be better to extend
format_repo_url subroutine to take additional parameter describing
_type_ of repo URL; it then would do styling internally. Which means
moving wrapping 'URL', 'Fetch URL' etc. in span element to
format_repo_url from the caller.
> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index 79d7eeb..631b20d 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -579,6 +579,11 @@ div.remote {
> display: inline-block;
> }
>
> +.metadata_remote_fetch_url,
> +.metadata_remote_push_url {
> + font-weight: bold;
> +}
> +
Good!
--
Jakub Narebski
Poland
ShadeHawk on #git
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html