Reported in http://qa.debian.org/daca/cppcheck/sid/git_1.7.2.3-2.2.html. Signed-off-by: Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx> --- xdiff-interface.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/xdiff-interface.c b/xdiff-interface.c index cd2285d..cd9fa33 100644 --- a/xdiff-interface.c +++ b/xdiff-interface.c @@ -212,8 +212,10 @@ int read_mmfile(mmfile_t *ptr, const char *filename) return error("Could not open %s", filename); sz = xsize_t(st.st_size); ptr->ptr = xmalloc(sz ? sz : 1); - if (sz && fread(ptr->ptr, sz, 1, f) != 1) + if (sz && fread(ptr->ptr, sz, 1, f) != 1) { + fclose(f); return error("Could not read %s", filename); + } fclose(f); ptr->size = sz; return 0; -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html