On 12/23/2010 10:05 AM, Junio C Hamano wrote: > This still leaves --no-bcc, --no-to and --no-cc in "no-foo overrides > sendemail.foo" tests, it seems. Do they also need to be fixed? No, those are handled completely separately. The --chainreplyto option is a boolean option, and the '--no' prefix is an automatic feature that is provided by Getopt::Long for boolean options (i.e. those suffixed with '!'). The three options you mentioned are actually distinct options that are configured in the call to GetOptions and are named so that they appear to be 'no-' prefixed automatic versions of --bcc, --to, and --cc, just like the boolean options. But there is really just a separate option named --no-bcc, that sets the variable $no_bcc that is distinct from the --bcc option which populates @bcclist. So, people with a somewhat old Getopt::Long (or those accustomed to prefixing '--no' without the dash) may get confused when they have to leave off the dash when negating --chainreplyto as --nochainreplyto, but _must_ use the dash when typing --no-bcc. If we want to be consistent with Getopt::Long which accepts both '--no-' and '--no', then we could add --nobcc, --noto, and --nocc. Not sure if it's worth the trouble. -Brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html