Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes: > What happens if there are any shell special characters in the path name > (or spaces, for that matter). Does this shell-escape the substituted path > name anywhere in the call chain? Good eyes. Thanks. You would need something like %'s (that is "'" modifier applied to 's' placeholder in strbuf_expand() to cause the expansion sq'ed), and then the caller must write something like clean = git-p4-filter --clean '%s' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html