On Sat, Dec 18, 2010 at 5:00 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: > Mark Lodato <lodatom@xxxxxxxxx> writes: > >> Finish the work of 0adda93 (Use parentheses and `...' where appropriate) >> to follow the rules set forth in Documentation/CodingGuidelines. >> >> Signed-off-by: Mark Lodato <lodatom@xxxxxxxxx> > > [...] > >> - Â Â "git describe [options] <committish>*", >> + Â Â "git describe [options] <committish>...", > > Isn't <sth>... one or more, while <sth>* is zero or more, i.e. shouldn't > <sth>* be replaced by [<sth>...]? Yes, I was confused by the * notation - one more reason to get rid of it! > Hmmm... I see that <sth>* was actively wrong if it was to mean zero or > more, so your change doesn't only make documentation more consistent, > but fixes errorneous use of convention. I think zero or more is correct, which is why I submitted patch 8/8 to change from <commit>... to [<commit>...]. Now I understand that all 8/8 was doing was fixing a mistake I introduced in this patch. I'll correct it in the next version. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html