Re: [PATCH 1/8] Refactor parse_loc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:
> Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:
> > +test_expect_success 'blame -L parses end' '
> > +	git blame -L1,1 tres >out &&
> > +	cat out &&
> > +	test $(wc -l < out) -eq 1
> > +'
> 
> What does this test exactly?  "end"?

That's the test I was referring to in the commit message:

  The new test is for a case that made me pause during debugging: the
  'blame -L with invalid end' test was the only one that noticed an
  outright failure to parse the end *at all*.  So make a more explicit
  test for that.

So I guess a more thorough test title would be

  blame -L parses <end> part of its argument

IOW, the test verifies that -L1,1 is not parsed the same as -L1, which
would result in *two* lines of output.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]