Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> I think the "commit = p->item" part is trying to do a tail >> recursion optimization, but this is a bit too clever to my >> liking (at first I mistook that the code forgot to re-point p at >> its parents list and incrementing cur_depth). > > I take it as a compliment ;-) > > Seriously again, would you like me to add a comment, or rather do away > with the tail recursion optimization? It is not a huge optimization > anyway. Maybe a cleverer way would be to use an object_array instead of a > commit_list? Leaving it as a compliment is just fine. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html