Ping.
On Tue, Nov 23, 2010 at 08:37, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote:
> The path given to the browser does not end in a slash, which results in bad
> path given to blame and broke [Up To Parent]. Also the path was not
> escaped before displaying.
>
> Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx>
>
> ---
> Âgit-gui/lib/browser.tcl | Â Â8 +++++++-
> Â1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl
> index c241572..a88a68b 100644
> --- a/git-gui/lib/browser.tcl
> +++ b/git-gui/lib/browser.tcl
> @@ -26,8 +26,14 @@ constructor new {commit {path {}}} {
> Â Â Â Âwm withdraw $top
> Â Â Â Âwm title $top [append "[appname] ([reponame]): " [mc "File Browser"]]
>
> + Â Â Â if {$path ne {}} {
> + Â Â Â Â Â Â Â if {[string index $path end] ne {/}} {
> + Â Â Â Â Â Â Â Â Â Â Â append path /
> + Â Â Â Â Â Â Â }
> + Â Â Â }
> +
> Â Â Â Âset browser_commit $commit
> - Â Â Â set browser_path $browser_commit:$path
> + Â Â Â set browser_path "$browser_commit:[escape_path $path]"
>
> Â Â Â Â${NS}::label $w.path \
> Â Â Â Â Â Â Â Â-textvariable @browser_path \
> --
> tg: (6f10c41..) bw/git-gui/fix-browser-up (depends on: master)
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html