Thiago Farina wrote: > 2010/12/9 Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx>: >> +static int git_config_from_sha1(config_fn_t fn, const char *sha1_name, void *data) >> +{ > > Is worth documenting the return value of this function and what it > does? It returns 0 on success otherwise returns -1. If that is the return value, then no. It is the usual in git (and other C programs that follow libc conventions). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html