Jeff King wrote: > > My workflow is that I post patch series for upstream review via 'git > > send-email'. Often, that results in feedback that requires me to > > amend/rebase my series, and post a v2 or v3 of the series. By adding > > 'git config notes.rewriteRef refs/notes/commits', I can add notes that > > will carry across my rebase, and remind me what I changed in v2 (for > > example, git notes add -m 'v2: fix foo, per mail xyz@xxxxxxxxxxx'). > > Yeah, that is a workflow that some others have mentioned using here, Incidentally it's what I wrote the rewriteRef support for :-) > too. And I think there is general agreement that notes should go after > the "---" in format-patch. We just need a working patch. > > Thomas posted one in February: > > http://article.gmane.org/gmane.comp.version-control.git/140819 > > But there were some issues and it never got polished. I got pretty frustrated with gfp being rather brittle. It is very hard to insert anything anywhere in the output stream in such a way that the output is not affected in any *other* scenario where this option is disabled. So I think a good angle of attack if you want to hack around on this would be to clean up gfp so that it becomes easier to work on, and/or come up with a better/cleaner place to insert the notes support than I had. That being said, the version I still use just shifts around a linefeed after the ---, IIRC, and so far nobody complained about that in practice ;-) -- Thomas Rast trast@{inf,student}.ethz.ch -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html