Jakub Narebski wrote: > Arnout Engelen wrote: >> On Tue, Dec 07, 2010 at 12:56:17PM -0800, Junio C Hamano wrote: >>>> + char origtemplate[255]; >>>> + strlcpy(origtemplate, template, 255); >>> >>> Why "255"? [...] > Why not use PATH_MAX instead of 255? The advantage I can see to 256 is a small speed-up in the "no errors" code path. Since the I/O would tend to be much more costly and PATH_MAX is self explanatory, using PATH_MAX does seem cleaner. I know you all are aware of this already; just thought I'd mention it while forwarding the original message to Arnout. :) Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html