Renà Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > Am 07.12.2010 18:39, schrieb Jonathan Nieder: >> while the core of the builtin version is >> >> get_patch_ids(&revs, &patch_id_opts, prefix); >> >> The latter function is static, introduced by v1.4.1~12^2~5 >> (format-patch: introduce "--ignore-if-in-upstream", 2006-06-25). >> >> So the answer is that "git cherry" is considered a variant on >> "git log" (like format-patch, show, and whatchanged) and that it uses >> "git log" internals. > > That's right. get_patch_ids() could be moved into patch-ids.c now and > then cmd_cherry() could get its own file in builtin/, though. Right, but the key word is "could". Is it hurting _anything_ to have it in the current place? I doubt it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html