Re: [PATCH] Corrected return values in post-receive-email.prep_for_email

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Care to explain in the change log message why the return value should
be 1 instead of 0?

On Tue, Dec 7, 2010 at 2:32 PM, Alan Raison <alan@xxxxxxxxxxxxxxxx> wrote:
> ---
> Âcontrib/hooks/post-receive-email | Â Â6 +++---
> Â1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/hooks/post-receive-email
> b/contrib/hooks/post-receive-email
> index 85724bf..020536d 100755
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -150,7 +150,7 @@ prep_for_email()
> Â Â Â Â Â Â Â Â Â Â Â Â# Anything else (is there anything else?)
> Â Â Â Â Â Â Â Â Â Â Â Âecho >&2 "*** Unknown type of update to $refname
> ($rev_type)"
> Â Â Â Â Â Â Â Â Â Â Â Âecho >&2 "*** Â- no email generated"
> - Â Â Â Â Â Â Â Â Â Â Â return 0
> + Â Â Â Â Â Â Â Â Â Â Â return 1
> Â Â Â Â Â Â Â Â Â Â Â Â;;
> Â Â Â Âesac
>
> @@ -166,10 +166,10 @@ prep_for_email()
> Â Â Â Â Â Â Â Âesac
> Â Â Â Â Â Â Â Âecho >&2 "*** $config_name is not set so no email will be
> sent"
> Â Â Â Â Â Â Â Âecho >&2 "*** for $refname update $oldrev->$newrev"
> - Â Â Â Â Â Â Â return 0
> + Â Â Â Â Â Â Â return 1
> Â Â Â Âfi
>
> - Â Â Â return 1
> + Â Â Â return 0
> Â}
>
> Â#
> --
> 1.7.3.1.msysgit.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]