Konstantin Khomoutov <flatworm@xxxxxxxxxxxxxxxxxxxxx> writes: >On Fri, Nov 26, 2010 at 02:38:55PM -0600, Jonathan Nieder wrote: > >> David Laban wrote at http://bugs.debian.org/605041: >> >> > Package: git-gui >> > Version: 1:1.7.2.3-2 >> > Severity: minor >> > >> > If I click into the messagebox and hit enter, nothing happens. >> > >> > This is annoying because if I'm adding a new paragraph to my commit message, >> > I will often do <click> <enter><enter> <start typing as normal> >> > >> > Don't ask me why I do this. I think enter is a lighter/easier to press >> > key than return, and is also on the path that my hand takes between the mouse >> > and the rest of the keyboard. >> > >> > I have also provisionally reported the following bug in tk, but I feel like >> > a bit of a n00b for doing so. >> > >> > http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997 >> >> I can't reproduce this because this laptop does not have a distinct >> "numpad enter" key. >I've tested it on Debian Squeeze and added another comment on the >upstream bug report. In short: KP_Enter is not bound to any action in >Tk text widgets in X11, at least in 8.5.9. > >But git-gui can be trivially patched to support this; that would be a >one-lineer. So if it is desired and will be accepted, I could prepare a >patch. > I've no problem with that. On unix the messagebox bindings are applied directly to the dialog window (.__tk__messagebox) and it does include Dialog in the bindtags so you could use bind Dialog <Key-KP_Enter> { .... } except that might affect other dialogs too. That might not be a problem. On Windows the messagebox is native so the bindings there are whatever are standard. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html