On Sun, Dec 5, 2010 at 3:29 PM, Thiago Farina <tfransosi@xxxxxxxxx> wrote: > On Sun, Dec 5, 2010 at 3:09 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> Â- "At my office there is a style guide indicating that each function >> Â should live in a module with some other functions and be named to >> Â indicate so (like perf, with its sched__* etc functions). ÂThe idea >> Â is that code with a simple high-level structure tends to be easier >> Â to understand and we need to understand the code we use. ÂCan we >> Â start changing the code to fit this style guide, so there is less >> Â resistance to using it at my office?" >> > For me that is a good reason and I think it matches with what I had in > mind but didn't write. Thanks for pointing it out. > Also I thought that as Junio already picked up the other patch. It's was a hint that the other functions that has "struct commit_list *l" as its parameters could be renamed as well. But I was wrong it seems. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html