On Sun, Dec 5, 2010 at 3:24 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Thiago Farina <tfransosi@xxxxxxxxx> writes: > >> Signed-off-by: Thiago Farina <tfransosi@xxxxxxxxx> > > I really do not like this. > I don't feel very strong about it. And as I learned from Jonathan, I don't care if you will take or not. I think my intention was good, but I can't please everybody I was just trying to put commit_list in a better shape and resemble it in a more explicit API. > The use of type "struct commit_list" to hold the set of parent commits is > incidental; if we had "struct commit_set", we would have written a > function with the same purpose, and named it the same "reduce_HEADS". > > Adding commit_list to the name makes the code harder to read (and type) > with little added benefit. Â"LIST"-ness is not the important part. > > If a function takes a commit_list, named "reduce_HEADS", What? reduce_HEADS ? HEADS with CAPSLOCK? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html